| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.0.2 |
| Request #14823 | Skip, not fail, when you are running tests | ||
|---|---|---|---|
| Submitted: | 2008-10-18 13:14 UTC | ||
| From: | doconnor | Assigned: | justinpatrin |
| Status: | Closed | Package: | DB_DataObject_FormBuilder (version CVS) |
| PHP Version: | 5.2.6 | OS: | |
| Roadmaps: | 1.0.0 | ||
[2008-10-18 13:14 UTC] doconnor
(Daniel O'Connor)
Description:
------------
Make use of a --SKIPIF-- section to inform the user when they haven't configured their environment, rather than failing.
Test script:
---------------
pear run-tests
Expected result:
----------------
Test skips
Actual result:
--------------
60) /pear/DB_DataObject_FormBuilder/tests/primaryKeyIsHidden.phpt
--- Expected
+++ Actual
@@ -1,2 +1 @@
-string(6) "hidden"
-string(4) "text"
\ No newline at end of file
+You need to put your DB DSN in the file "DSN" and import movie.sql before running these tests
\ No newline at end of file
Comments
[2008-10-20 17:50 UTC] justinpatrin
(Justin Patrin)
That would be great if I could do it in the config.php include....if not I have to put it in every single phpt file, which seems a bit silly.
[2008-10-20 18:15 UTC] justinpatrin
(Justin Patrin)
I've added a simple skipif for the create.phpt. Let me know if that works for you.
[2008-10-26 17:26 UTC] justinpatrin
(Justin Patrin)
This bug has been fixed in CVS.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.
[2008-10-27 04:51 UTC] doconnor
(Daniel O'Connor)
Oops, not quite skipping yet.
If you just change the wording in config.php to start with 'skip'.
IE:
echo 'skip You need to put your DB DSN in the file "DSN" and import movie.sql before running these tests';
PEAR's test runner looks explicitly for it.
[2008-10-27 05:58 UTC] justinpatrin
(Justin Patrin)
*sigh*, all right. It seems obfuscated for that code to have a random "skip" at the beginning, though.