| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.10.15 |
| Bug #16057 | -r is limited to 4 directories in depth | ||
|---|---|---|---|
| Submitted: | 2009-03-28 01:10 UTC | ||
| From: | cellog | Assigned: | dufuz |
| Status: | Closed | Package: | PEAR (version 1.8.0RC1) |
| PHP Version: | 5_3 CVS-2009-03-27 | OS: | |
| Roadmaps: | 1.8.0 | ||
[2009-03-28 01:10 UTC] cellog
(Greg Beaver)
Description:
------------
pear run-tests -r tests/
does not detect test files with this directory layout:
tests/
Registry/
package/
basic/
blah.phpt
to test, run the above command within svn checkout of all/Pyrus
Comments
[2009-03-28 05:41 UTC] dufuz
(Helgi Þormar Þorbjörnsson)
-Assigned To:
+Assigned To: dufuz
-Roadmap Versions:
+Roadmap Versions: 1.8.0RC2
[2009-03-29 12:13 UTC] dufuz
(Helgi Þormar Þorbjörnsson)
I created the exact same structure as you described, put blah.phpt with a simple one line echo statement and ran this:
[helgi@Stewie pearbug]$ pear run-tests -r tests/
Running 1 tests
PASS Silly[tests/Registry/package/basic/blah.phpt]
TOTAL TIME: 00:00
1 PASSED TESTS
0 SKIPPED TESTS
Worked just fine, then I went to all/Pyrus and ran this and AllRegistries did not pick up on package, which is midely odd to be honest.
[2009-03-29 12:32 UTC] dufuz
(Helgi Þormar Þorbjörnsson)
Okey AllRegistries doesn't have a phpt file in package, so I just don't see the issue, can you describe this issue better ?
[2009-04-04 04:45 UTC] dufuz
(Helgi Þormar Þorbjörnsson)
Ping, I am still not seeing any sorts of issues.
[2009-04-04 04:53 UTC] dufuz
(Helgi Þormar Þorbjörnsson)
Just after saying that, I found the issue.
System::find was being called with maxdepth, with -r it is 4 whic you added Greg :-)
For fun I bumped that up to 14 and it finds all the tests. I believe maxdepth was added merely because if -r is not provided it should not drill down. I see no reason why we wouldn't provide a infinitive recursion so I will change it so maxdepth = 1 provided if -r is missing but if -r is provided that parameter will be omitted.
[2009-04-04 05:00 UTC] dufuz
(Helgi Þormar Þorbjörnsson)
-Summary: -r does not traverse empty directories to
sub-directories
+Summary: -r is limited to 4 directories in depth
-Status: Assigned
+Status: Closed
This bug has been fixed in CVS.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.