Description: ------------ The symmetrize() function does not compute the $max_length correctly. Right now, it goes through each of the rows and finds the longest row and sets $max_length to it. But in the next section of code it only checks if ($max_length == 0). It should also check if $max_length is less than $header_length in cases where the $header_length is longer than any of the $row_length. I've pasted the patch code in the "Test Script" section. Additionally, the documentation says the symmetrize() should return an array, but currently it doesn't. Either the documentation should be updated or the function should return an array. Thanks, Konstantin Test script: --------------- Replace lines 447-449 in v1.0.0 with the following to get the correct behavior: $header_length = count($this->headers); if (($max_length == 0) || ($header_length > $max_length)) { $max_length = $header_length; }

Can we have an actual executable test script to demonstrate the problem?

Here is the code to show the problem: require('File/CSV/DataSource.php'); $csv = new File_CSV_DataSource; /* Load and parse the CSV file. */ if ($csv->load($_FILES['import_contacts']['tmp_name']) === true) { /* Outlook CSV is notoriously *not* symmetric. */ if ($csv->isSymmetric() === false) { /* Make the length of all rows and headers the same. */ $csv->symmetrize(); } $data = $csv->connect(); } The symmetrize() function will not properly "symmetrize" the data if the header is longer than any of the rows (as is the case in Outlook CSV files, which I have attached in the next comment so you can test it yourself) Thanks, Konstantin

Added patch outlook_sample.csv.

Whoops, didn't notice this bug until now. I would give it a quick check but please provide the current php version that you are running!

I am running PHP 5.3.1.

Thanks for the version, yeah perhaps your right! I will have this fixed sometime this week. Just one observation: *The patch* which is a csv file. is not quoted correctly! some lines start with only one quote and some end with an unclosed one. Example: header_1, header_2 field_1, field_2 field_1, " ", field_2 you might wanna watch out for those as well!