Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.2

Request #17415 escapeshellargs
Submitted: 2010-05-19 18:06 UTC
From: dietmarp Assigned: mrook
Status: Closed Package: VersionControl_SVN (version 0.3.3)
PHP Version: 5.2.10 OS: Windows
Roadmaps: 0.3.4    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 50 - 18 = ?

 
 [2010-05-19 18:06 UTC] dietmarp (Dietmar Pointner)
Description: ------------ Every command argument must be escaped with "escapeshellarg()" in VersionControl_SVN::run() Solution: ... Line 638 if (sizeof($args) > 0) { $this->args = $this->escapeShellArgs($args); } ... function escapeShellArgs($args) { foreach ($args AS $key => $arg) { $args[$key] = escapeshellarg($arg); } return $args; }

Comments

 [2010-05-21 05:56 UTC] doconnor (Daniel O'Connor)
-Type: Bug +Type: Feature/Change Request
I don't suppose you'd care to do a patch; and make use of http://au2.php.net/array_map ?
 [2010-05-21 06:45 UTC] doconnor (Daniel O'Connor)
-Status: Open +Status: Feedback
Thank you for taking the time to report a problem with the package. This problem may have been already fixed by a previous change that is in the SVN of the package. Please checking out the SVN repository of this package and upgrade svn checkout svn.php.net/repository/pear/packages/VersionControl_SVN/trunk pear upgrade package2.xml or pear upgrade package.xml If you are able to reproduce the bug with the latest SVN, please change the status back to "Open". Again, thank you for your continued support of PEAR.
 [2010-08-12 22:40 UTC] mrook (Michiel Rook)
-Status: Feedback +Status: Assigned -Assigned To: +Assigned To: mrook -Roadmap Versions: +Roadmap Versions: 0.3.4
 [2010-08-12 22:49 UTC] mrook (Michiel Rook)
-Status: Assigned +Status: Closed
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.