Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.0
Bug #17910 VersionControl_Git_Util_Command::createCommandString() must be public
Submitted: 2010-09-29 20:42 UTC
From: ebihara Assigned: ebihara
Status: Closed Package: VersionControl_Git (version 0.4.2)
PHP Version: 5.3.3 OS:
Roadmaps: 0.4.3    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 19 - 14 = ?

 
 [2010-09-29 20:42 UTC] ebihara (Kousuke Ebihara)
Description: ------------ VersionControl_Git_Util_Command::createCommandString() must be public. I've written this method as protected because this is used by only VersionControl_Git_Util_Command::execute() now. But my judgment was not good. Because, * This class' role is similar to objective of "utility class". So I should make an effort to make many methods public. * Arguments and prerequisites for running (::$subCommand must be specified) of ::createCommandString() are equal to ::execute()'s one. It is able to be called individually. There is nothing to do for calling this method from ::execute(). * ::createCommandString() doesn't change any properties.

Comments

 [2010-09-29 20:49 UTC] ebihara (Kousuke Ebihara)
-Status: Open +Status: Closed -Assigned To: +Assigned To: ebihara
This bug has been fixed in Git repository. http://github.com/ebihara/VersionControl_Git/commit/8df728b448ca11c84845855713e8abec77f4c1cf