Description: ------------ When trying to document a class derived from the internal class "Exception" v1.3.0 throws following exception: Writing ./docs/__filesource/fsource_Rde__RdeBaseException.php.html Procedural Page Elements... Classes...PHP Fatal error: Uncaught exception 'ReflectionException' with message 'Cannot determine default value for internal functions' in /usr/lib/php/pear/PhpDocumentor/phpDocumentor/ParserElements.inc:1735 Stack trace: #0 /usr/lib/php/pear/PhpDocumentor/phpDocumentor/ParserElements.inc(1735): ReflectionParameter->getDefaultValue() #1 /usr/lib/php/pear/PhpDocumentor/phpDocumentor/Converter.inc(4720): parserMethod->getOverrides(Object(HTMLframesConverter)) #2 /usr/lib/php/pear/PhpDocumentor/phpDocumentor/Converter.inc(4140): Converter->getFormattedOverrides(Object(parserMethod)) #3 /usr/lib/php/pear/PhpDocumentor/phpDocumentor/Converters/HTML/frames/HTMLframesConverter.inc(1070): Converter->convertMethod(Object(parserMethod), Array) #4 /usr/lib/php/pear/PhpDocumentor/phpDocumentor/Converter.inc(3970): HTMLframesConverter->convertMethod(Object(parserMethod)) #5 /usr/lib/php/pear/PhpDocumentor/phpDocumentor/Converter.inc(1920): Converter->Convert(Object(parserMethod)) #6 /usr/lib/php/pear/PhpDocumentor/phpDocumentor/IntermediateParser. in /usr/lib/php/pear/PhpDocumentor/phpDocumentor/ParserElements.inc on line 1735

As a quick workaround i've added following try/catch arround the offending source line in ParserElements.inc which solves the problem for me (but i can't guaranty that this leads to expected results in all circumstances): try { $value = $param->isOptional() ? var_export($param->getDefaultValue(), true) : null; } catch (Exception $e) { $value = null; }

I experienced the same bug here today. The workaround works here too. Since I experimented this bug right after upgrading from php 5.1.6 to php 5.2, I strongly suspect it has something to do with this upgrade (debian etch). Note also the following lines, just before the stack trace : Converting /path/src/myapp/myfwk/lib/BF_Exception.class.phpWARNING: class BF_Exception in package myfwk parent not found in @see parent::__construct() Writing phpdocs/__filesource/fsource_myfwk_framework_myappmyfwklibBF_Exception.class.php.html WARNING: class BF_Exception in package myfwk parent not found in @see parent::__construct() Could it be that PhpDoc is looking for the source file of php base exception class (since class BF_Exception extends Exception) which would undoubtedly be doomed to fail, wouldn't it ? Oh, by the way, I don't myself use the @see tag (there), it's coming out from phpdoc internals...

Below is the patch for me. I had to deal with exceptions in 3 places. I only catch ReflectionExceptions. --- ParserElements.inc.orig 2006-12-12 14:48:32.000000000 -0500 +++ ParserElements.inc 2006-12-12 14:53:58.000000000 -0500 @@ -1098,7 +1098,11 @@ } $doc = new parserDocBlock; foreach ($method->getParameters() as $param) { - $value = $param->isDefaultValueAvailable() ? var_export($param->getDefaultValue(), true) : null; + try { + $value = $param->isDefaultValueAvailable() ? var_export($param->getDefaultValue(), true) : null; + } catch (ReflectionException $e) { + $value = null; + } if ($param->isPassedByReference()) { $var->addParam('&$' . $param->getName(), $value, $param->isOptional(), $param->getClass()); @@ -1732,7 +1736,11 @@ } $doc = new parserDocBlock; foreach ($method->getParameters() as $param) { - $value = $param->isOptional() ? var_export($param->getDefaultValue(), true) : null; + try { + $value = $param->isOptional() ? var_export($param->getDefaultValue(), true) : null; + } catch (ReflectionException $e) { + $value = null; + } if ($param->isPassedByReference()) { $var->addParam('&$' . $param->getName(), $value, $param->isOptional(), $param->getClass()); @@ -1852,7 +1860,11 @@ } $doc = new parserDocBlock; foreach ($method->getParameters() as $param) { - $value = $param->isOptional() ? var_export($param->getDefaultValue(), true) : null; + try { + $value = $param->isOptional() ? var_export($param->getDefaultValue(), true) : null; + } catch (ReflectionException $e) { + $value = null; + } if ($param->isPassedByReference()) { $var->addParam('&$' . $param->getName(), $value, $param->isOptional(), $param->getClass()); @@ -2275,4 +2287,4 @@ } } -?> \ No newline at end of file +?>

the patch cannot be used. Why? phpDocumentor must run in BOTH php4 and php5. try = fatal error in php 4. If the choice is splitting the files for php4 and php5 or not doing it, we'll be not doing it.

Does this scenario imply that any internal PHP classes that are NEW WITH PHP5 need to somehow be set up as "mock objects" at the beginning of a phpdoc run that recognizes it is running against PHP4? Or, should phpdoc be treating ANY missing internal classes (like the base Exception class would be in PHP4) just like any other non-internal class would be treated... with a note in the errors.html file saying "hey dude, you extended the Exception class, but I couldn't find it"... ??

no mock objects. The Reflection extension is used to detect internal classes, the problem is that we're trying to code against incompatible PHP 5 versions (PHP 5.0 doesn't have some features of PHP 5.1) and so throws exceptions when we try to use a feature, but there is no easy way to detect in advance what is available in the method signature reflection. Using try/catch would be great, but then we lose php 4, so it's a catch-22

have you tried this with version 1.3.1?

Greg, I am using this with version 1.3.1. I understand how you would not want to break PHP4 compatability. It just never occured to me try/catch was a PHP5 thing. I'll see if can figure ou something php4/5 compatiable.

Would a custom wrapper function be an ugly way to handle this? Something that you could use to wrap a "trouble-maker" function, that would itself figure out if try/catch is available in the PHP environment, and use some other means of accomplishing the try/catch concept if it's not available? Then again, if there was an obvious alternative to try/catch, I suppose someone would have already mentioned it... I guess I could step back a moment and ask if someone's already tested this scenario against the stable 5.2 release... ?

Could someone hook me up with a test file that triggers this problem? I'd like to set up a v1.3.1-on-v5.2.0 setup and work on some ideas, but I need a testfile that is known to trigger this error (rather than trying to divine one myself with my Y-shaped stick).

This will do to reproduce the bug: <?php class MyException extends Exception { public function __construct () { } } ?> Throws the following error (PHP 5.2.1): Fatal error: Uncaught exception 'ReflectionException' with message 'Cannot determine default value for internal functions' in (...)/PhpDocumentor/phpDocumentor/ParserElements.inc:1735 Without __construct(), no exception gets thrown.

Replacing line 1735 with: $value = ($param->isOptional() && !$method->isInternal()) ? var_export($param->getDefaultValue(), true) : null; Prevents the exception being thrown (without try-catch logic). Maybe log an error 'Cannot determine default value for builtin method' when checking for internal parameters?

I'm also experiencing this problem. That last line replacement suggestion worked great for me.

I've tested that one-line change to ParserElements.inc against that small test file MyException.class.php, and I do see that running v1.3.1 against PHP v5.2.0 does avoid it from crashing. The output doc looks fine, cleanly showing that Exception is the parent. It runs clean against PHP v5.1.6 and v4.4.4 also. I'm going to test it now against PhpDoc's CVS HEAD, documenting the PhpDoc codebase itself, as a large-scale test of the patch.

This patch seems to be safe on the CVS Head. "netmaster", "patrice", and "zippy1981", are you able to try that one-line patch against the codebases you are each documenting, to see if it solves the problems for each of you cleanly?

This one-line fix works here. Thanks a lot !

This bug has also been recently reported on Sourceforge (#1656902). I have attached a patch file there containing bigtree's one-line fix.

Fix ok'd by Greg, committed to CVS.