Vote Details for "Services_Yadis" by aharvey
| » Details |
|---|
|
| » Comment |
|
+1 assuming a couple of minor issues are fixed: - Services_Yadis_Service::getDomObject() fails at present. Changing $this->serviceNode to $this->_serviceNode corrects this. I also suspect that using the approach in http://au2.php.net/manual/en/function.dom-import-simplexml.php#66996 for the SimpleXML to DOM conversion will be quicker, too, given that it avoids a reparse. - The example refers to $service->getXmlObject(); presumably this should be getSimpleXmlObject(). Furthermore, it attempts to load Priority as a child element, rather than an attribute: changing the line to the following worked for me: echo 'Priority is ', $service->getSimpleXmlObject()->attributes()->priority, PHP_EOL; All in all, though, it's the usual good work, Pádraic, and I'm sure people wanting to use OpenID are encouraged by the continuing progress to that end. |