» Details |
---|
|
» Comment |
While the code itself looks good, you really need to work on the docblocks since most methods miss them. Your factory classes should be named PHP_UML_XMI_Factory_v1, not PHP_UML_XMI_Factory1 and *2 as they are now. This should also be reflected in the file layout. Constructs like <?php else throw new PHP_UML_Exception('File '.$filename.' does not exist.'); ?> are not allowed, you need {} around the block. |