Vote Details for "Validate_IR" by dbezborodov

» Details
» Comment
Looks alright to me. Not sure why it doesn't extend a Validate_Interface or something, but that is out of scope for this review.



I noticed one tiny bug:

'/[0-9]{4}-?[0-9]{4}-?[0-9]{4}-?[0-9]{4}$/'

is missing the start ^
should be:

'/^[0-9]{4}-?[0-9]{4}-?[0-9]{4}-?[0-9]{4}$/'

test to prove that is broken would be nice before you fix it.


Also, the ssn could do with some comments explaining what's going on there. Looks complicated. :)

Good work, squire.