Vote Details for "Testing_DocTest" by jausions
| » Details |
|---|
|
| » Comment |
|
- To be able to enforce the Config::singleton() you may consider creating a protected __construct() - Make sure you run PHP_CodeSniffer. I noticed a couple of minor issues, such as missing spaces around => in foreach loops, or around = for default values of method's arguments - Where is the fclose() matching the fopen() call in Outputter_Default::__construct() ? - the "else if ... self::KW_DOCTEST_* " blocks of code in Parser_Default::parse() might be cleaner (and faster) with a switch {} block instead. (same for Parser_Default::_handleLineContinuation()) |