Vote Details for "I18N_UnicodeNormalizer" by justinpatrin
| » Details |
|---|
|
| » Comment |
|
Comments should be before the line they are for. Having them after the line makes the code even more dense than it needs to be and harder to read. Conditional code should not use "or" in a normal line of code. It makes the code generally harder to understand. Please use a standard if statement instead of e.g.: self::$combining or self::$combining = require($this->compiled['combining']); Is there a particular reason you're using self:: instead of $this->? || and && are more generally used than "or" and "and" when writing conditionals. |