Vote Details for "PagamentoCerto" by ktlacaelel

» Details
Voter: Kazuyoshi Tlacaelel Vote: +1 (conditional) Reviews: Cursory source review
» Comment
Hello Pedro! 1. ran codesniffer and got the following results thought you may want to take a look at those! $ phpcs Payment/ \| grep -i '^\w' FILE: ...u/Desktop/Payment_PagamentoCerto-0.2.0/Payment/PagamentoCerto/Order.php FOUND 10 ERROR(S) AND 0 WARNING(S) AFFECTING 10 LINE(S) FILE: .../Payment_PagamentoCerto-0.2.0/Payment/PagamentoCerto/PagamentoCerto.php FOUND 2 ERROR(S) AND 2 WARNING(S) AFFECTING 4 LINE(S) FILE: ...top/Payment_PagamentoCerto-0.2.0/Payment/PagamentoCerto/Transaction.php FOUND 2 ERROR(S) AND 0 WARNING(S) AFFECTING 2 LINE(S) FILE: ...ktop/Payment_PagamentoCerto-0.2.0/Payment/PagamentoCerto/XmlBuilder.php FOUND 9 ERROR(S) AND 4 WARNING(S) AFFECTING 11 LINE(S) ----------------- 2. properties are camelcased ( maybe create dto data access objects ) with getters and setters? 3. code is readable, easy to understand and has tests. that is great!