Vote Details for "Console_CommandLine" by saltybeagle
| » Details |
|---|
|
| » Comment |
|
Looks great.. only one comment on what should be a thrown error of some sorts, or handled gracefully: When using an xml definition file, (from your example2) - It doesn't appear that any error is thrown if the XML file is not found... if the file given is not valid the user is given: PHP Warning: DOMDocument::load(): I/O warning : failed to load external entity "/Users/bbieber/ex2.xml" in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 58 Warning: DOMDocument::load(): I/O warning : failed to load external entity "/Users/bbieber/ex2.xml" in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 58 PHP Warning: DOMDocument::relaxNGValidate(): I/O warning : failed to load external entity "/usr/local/php5/lib/php/data/xmlschema.rng" in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 106 Warning: DOMDocument::relaxNGValidate(): I/O warning : failed to load external entity "/usr/local/php5/lib/php/data/xmlschema.rng" in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 106 PHP Warning: DOMDocument::relaxNGValidate(): xmlRelaxNGParse: could not load /usr/local/php5/lib/php/data/xmlschema.rng in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 106 Warning: DOMDocument::relaxNGValidate(): xmlRelaxNGParse: could not load /usr/local/php5/lib/php/data/xmlschema.rng in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 106 PHP Warning: DOMDocument::relaxNGValidate(): Invalid RelaxNG in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 106 Warning: DOMDocument::relaxNGValidate(): Invalid RelaxNG in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 106 PHP Notice: Trying to get property of non-object in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 131 Notice: Trying to get property of non-object in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 131 PHP Warning: Invalid argument supplied for foreach() in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 131 Warning: Invalid argument supplied for foreach() in /usr/local/php5/lib/php/Console/CommandLine/XmlParser.php on line 131 |