Vote Details for "CodeGen_MySQL_UDF" by sfrausch

» Details
Voter: Stefano F. Rausch Vote: +1 (conditional) Reviews: Cursory source review
» Comment
Good addition. Precondition for the +1 from my side is: - comply with the PCS! - remove the keyword 'var' in CodeGen_Mysql_UDF_Extension and in CodeGen_Mysql_UDF_Element_Function: <quote="http://www.php.net/manual/en/language.oop5.visibility.php"> Note: The PHP 4 method of declaring a variable with the var keyword is no longer valid for PHP 5 objects. For compatibility a variable declared in php will be assumed with public visibility, and a E_STRICT warning will be issued. </quote> as you're coding for PHP5.